-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ignore_changes lifecycle flag #2525
Conversation
+1 |
50cfaa5
to
b728c62
Compare
+1! |
Yes! Just came looking for this after:
as I can't let Terraform manage this EIP. |
👍 |
Unfortunately, doesn't seem to work:
Maybe this is just an issue with resources with count? |
Hi @robzienert , please have a look at #2018 (comment) where a meta-paremeter is proposed to ignore changes in targeted attributes of a resource. |
@pmoust I like this a lot more. Not sure why I didn't see that issue when I was originally working on this PR. I'll work on getting this updated this coming weekend to use a list of properties, rather than being resource-level. |
Would love to see this feature! 👍 |
280cde2
to
cba29f2
Compare
Finally got around to updating the PR. Right now it ignores attributes by their name, not state ID, but I would like to support both however I'm running into an issue with my implementation. For example: I have a dynamic route on an |
cba29f2
to
9c0efe4
Compare
@robzienert This is looking good! If you could add a covering unit test or two in our higher level context tests, I think this should be merge-able. Let me know if the tests are any trouble and one of us can help pick them up. |
Welcome back @phinze. Will look into this - until then, do you have any feedback re my previous comment? |
Oh right! Sorry about missing that, @robzienert
I'm not sure we should expose the internals of state storage as an interface here. Why would you need to do this instead of just the attribute names? Based on your example, it looks like you're trying to partially manage the routes on a route table? For that use case I think we should go for a separate |
Not exposing the state ID is fine, I was just thinking if people wanted to ignore an individual list item - but that would certainly be better suited with a join resource like |
Would love to see that landing in 0.6.4, thanks for your efforts |
9c0efe4
to
a1939e7
Compare
PR updated with a context test. |
Looks good! Thanks for all your work on this, @robzienert 🙇 |
Adding ignore_changes lifecycle flag
Finally :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
First stab at adding an "ignore_updates" lifecycle flag; addresses #2437.